-
Notifications
You must be signed in to change notification settings - Fork 46
feat!: re-work messaging parts and sharding #2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the standalone message-hash
package by merging its functionality into core
, introduces a messageHashStr
convenience wrapper with accompanying tests, and updates encryption decoders/interfaces to use a new IEncryptedMessage
type.
- Remove
packages/message-hash
and update workspaces/manifests - Merge
messageHash
(+ newmessageHashStr
) intocore
and extend test coverage - Update encryption decoders and shared interfaces to use
IEncryptedMessage
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
packages/message-hash/** | Removed obsolete standalone message-hash package files |
packages/core/src/lib/message_hash/message_hash.ts | Added messageHashStr and updated documentation comments |
packages/core/src/lib/message_hash/message_hash.spec.ts | Renamed suite and added tests for messageHashStr |
packages/interfaces/src/message.ts | Introduced IEncryptedMessage , cleaned up duplicate definitions |
packages/message-encryption/src/symmetric.ts, ecies.ts, decoded_message.ts |
Updated decoders to return IEncryptedMessage |
packages/core/src/index.ts | Exported messageHash and messageHashStr from core entry |
.size-limit.cjs | Updated size-limit path to point at core bundle |
package.json, .release-please-manifest.json |
Removed message-hash package references |
Comments suppressed due to low confidence (2)
.size-limit.cjs:62
- The
path
field is now an array, but size-limit typically expects a string. Verify that this syntax is supported or change back to a string to prevent configuration errors.
path: ["packages/core/bundle/index.js"],
packages/core/src/index.ts:24
- [nitpick] You've exposed
messageHashStr
at the core entrypoint, but the top-level README or public documentation hasn't been updated to mention this new API. Consider adding usage examples to keep docs in sync.
export { messageHash, messageHashStr } from "./lib/message_hash/index.js";
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Due to root message related types (i.e
IDecodedMessage
) we incur some inefficiency and lack of needed properties.Proposed Solution / Feature Design
We need to do couple of things to hide complexity of types and make them more consumer firendly:
proto
package oninterfaces
;message-encryption
tocore
package;Notes
createDecoder
andcreateEncoder
onIWaku
#2352Checklist