feat(filter)!: new simpler filter API #2092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Based on the Reliability Epic, we want:
This also ties in with #2022, where Filter API is hard-to-understand, and involves multiple steps:
Solution
Based on the fact that
decoder
has information about thepubsubTopic
as well ascontentTopic
, we can usedecoders
to fetch information about both the topics, and API can be condenses into:Notes
filter.subscribe()
dependency onIReceiver
#1979, whereIReceiver
dependency is renamed tosubscribeWithFilter
instead, andsubscribe()
is brought out as the primary API (feat: removefilter.subscribe()
dependency onIReceiver
#1979 (comment))Contribution checklist:
!
in title if breaks public API;