-
Notifications
You must be signed in to change notification settings - Fork 534
add subsmt m2 #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add subsmt m2 #1254
Conversation
Hi @YanOctavian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YanOctavian sry for the late reply. I've evaluated the delivery, and while most of it worked out-of-the-box without any problems, I did unfortunately run into some problems. Here is my evaluation. Any idea what went wrong?
From my eval:
Most deliverables worked out-of-the-box. However, the coverage report threw an error, a dep seems to be missing here. Also, the smoke test failed: The POST /update call would timeout when sent with the suggested request body:
{ "address": "1H4GsGKaAv6VCwgx7gRgPm9AmCKqzEDjb2GyWoERj9xBRAH", "balance": "1000000000000", "nonce": 1, "prefix": 0 }
@takahser Thank you for your feedback and great work, I will fix it soon |
@takahser I have submitted the latest update. Regarding the error in the test report, it is because you have not downloaded tarpaulin locally. Just execute the command |
@takahser I have conducted relatively comprehensive testing. If you'd like to continue testing the |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2104