Skip to content

add subsmt m2 #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add subsmt m2 #1254

wants to merge 1 commit into from

Conversation

YanOctavian
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2104

@YanOctavian YanOctavian mentioned this pull request Mar 27, 2025
10 tasks
@github-actions github-actions bot added the stale label Apr 11, 2025
@takahser takahser self-assigned this Apr 14, 2025
@takahser takahser self-requested a review April 14, 2025 09:03
@takahser
Copy link
Contributor

Hi @YanOctavian
Sorry for the delay here. Will start with the evaluation of your delivery shortly and provide feedback here.

Copy link
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanOctavian sry for the late reply. I've evaluated the delivery, and while most of it worked out-of-the-box without any problems, I did unfortunately run into some problems. Here is my evaluation. Any idea what went wrong?

From my eval:

Most deliverables worked out-of-the-box. However, the coverage report threw an error, a dep seems to be missing here. Also, the smoke test failed: The POST /update call would timeout when sent with the suggested request body:

{
"address": "1H4GsGKaAv6VCwgx7gRgPm9AmCKqzEDjb2GyWoERj9xBRAH",
"balance": "1000000000000",
"nonce": 1,
"prefix": 0
}

@YanOctavian
Copy link
Contributor Author

@YanOctavian sry for the late reply. I've evaluated the delivery, and while most of it worked out-of-the-box without any problems, I did unfortunately run into some problems. Here is my evaluation. Any idea what went wrong?

From my eval:

Most deliverables worked out-of-the-box. However, the coverage report threw an error, a dep seems to be missing here. Also, the smoke test failed: The POST /update call would timeout when sent with the suggested request body:

{
"address": "1H4GsGKaAv6VCwgx7gRgPm9AmCKqzEDjb2GyWoERj9xBRAH",
"balance": "1000000000000",
"nonce": 1,
"prefix": 0
}

@takahser Thank you for your feedback and great work, I will fix it soon

@YanOctavian
Copy link
Contributor Author

@YanOctavian sry for the late reply. I've evaluated the delivery, and while most of it worked out-of-the-box without any problems, I did unfortunately run into some problems. Here is my evaluation. Any idea what went wrong?
From my eval:

Most deliverables worked out-of-the-box. However, the coverage report threw an error, a dep seems to be missing here. Also, the smoke test failed: The POST /update call would timeout when sent with the suggested request body:

{
"address": "1H4GsGKaAv6VCwgx7gRgPm9AmCKqzEDjb2GyWoERj9xBRAH",
"balance": "1000000000000",
"nonce": 1,
"prefix": 0
}

@takahser Thank you for your feedback and great work, I will fix it soon

@takahser I have submitted the latest update. Regarding the error in the test report, it is because you have not downloaded tarpaulin locally. Just execute the command cargo install cargo-tarpaulin. I have also added this in the document. Thanks again

@YanOctavian
Copy link
Contributor Author

@takahser I have conducted relatively comprehensive testing. If you'd like to continue testing the update, you can delete the old image with docker rmi -f yanoctavian/smt:latest and then run docker-compose up. Looking forward to your feedback, and thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants