Skip to content

Change originalOpener to be optional #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jun 14, 2024

Since the opener Id would not be present on each context, we think it makes sense to actually define it as an optional non-nullable attribute.


Preview | Diff

@OrKoN OrKoN requested a review from Lightning00Blade June 14, 2024 12:47
@OrKoN OrKoN requested review from whimboo and jgraham June 14, 2024 12:48
@OrKoN
Copy link
Contributor Author

OrKoN commented Jun 14, 2024

@jgraham @whimboo as a follow-up to the opener ID change, we actually think it will be more convenient to declare it as optional so that null values are not sent around. WDYT?

@whimboo
Copy link
Contributor

whimboo commented Jun 14, 2024

@jgraham @whimboo as a follow-up to the opener ID change, we actually think it will be more convenient to declare it as optional so that null values are not sent around. WDYT?

So only top-level browsing context will get an opener, right? Or are there also situations when the opener can be there null as well? Probably not, but given that we use the same BrowsingContextInfo struct for all browsing contexts it would make sense to set it as optional. I'm going to give @jgraham the final last word here.

@OrKoN
Copy link
Contributor Author

OrKoN commented Jun 17, 2024

So only top-level browsing context will get an opener, right? Or are there also situations when the opener can be there null as well?

null would also mean there is no opener, so not setting the attribute in that case sounds fine to me.

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve the changes by last week.

@OrKoN OrKoN marked this pull request as draft June 17, 2024 09:39
Lightning00Blade added a commit to GoogleChromeLabs/chromium-bidi that referenced this pull request Jun 17, 2024
We should wait until w3c/webdriver-bidi#730 is
resolved.

Closes #2315
Closes #2296

---------

Co-authored-by: Browser Automation Bot <[email protected]>
@OrKoN
Copy link
Contributor Author

OrKoN commented Jun 18, 2024

As discussed offline, we could return unset for child navigables but we have no strong arguments for doing it and would like to keep the spec as is.

@OrKoN OrKoN closed this Jun 18, 2024
@OrKoN OrKoN deleted the orkon/opener-id-opt branch June 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants