-
Notifications
You must be signed in to change notification settings - Fork 53
Change originalOpener to be optional #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So only top-level browsing context will get an opener, right? Or are there also situations when the opener can be there |
null would also mean there is no opener, so not setting the attribute in that case sounds fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to approve the changes by last week.
We should wait until w3c/webdriver-bidi#730 is resolved. Closes #2315 Closes #2296 --------- Co-authored-by: Browser Automation Bot <[email protected]>
As discussed offline, we could return unset for child navigables but we have no strong arguments for doing it and would like to keep the spec as is. |
Since the opener Id would not be present on each context, we think it makes sense to actually define it as an optional non-nullable attribute.
Preview | Diff