Clarify that DER lengths vary with INTEGER magnitude and curve size #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example copied from test vectors "ES256 Credential with very long credential ID" whose signature happens to have components of different lengths.
emlun
requested review from
rlin1,
MasterKale,
timcappalli,
selfissued and
akshayku
akshayku
approved these changes
Jul 15, 2025
timcappalli
approved these changes
Jul 15, 2025
|
Could you also make one value shorter than 32 bytes? Because this is the other edge-case. |
|
I considered it, but figured it's good to represent the common case too. But fair enough, done in 81514c7. |
emlun
force-pushed
the
issue-2314-der-example
branch
from
488684b to
81514c7
Compare
MasterKale
approved these changes
Jul 30, 2025
selfissued
approved these changes
Aug 6, 2025
|
@rlin1 Can you please review |
rlin1
approved these changes
Aug 6, 2025
github-actions bot
added a commit
that referenced
this pull request
Aug 6, 2025
SHA: cc8c1e1 Reason: push, by MasterKale Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to johnperez416/webauthn
that referenced
this pull request
Aug 6, 2025
SHA: cc8c1e1 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2314.
The new example is copied from the "ES256 Credential with very long credential ID" test vector whose signature happens to have components of different lengths.
Preview | Diff