-
Notifications
You must be signed in to change notification settings - Fork 218
device public key extension #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
144 commits
Select commit
Hold shift + click to select a range
6719e05
device-bound Public Key pair extension
equalsJeffH 4a6b8fe
further hacking...
equalsJeffH 5d1662d
nearly complete tho likely needs to be re-worked to include attestati…
equalsJeffH 1622df2
add 'device-bound key'
equalsJeffH 5e684aa
in-progress updates...
equalsJeffH 71afdbe
further in-progress updates...
equalsJeffH 8040d13
further in-progress updates...
equalsJeffH 38131e6
Merge branch 'main' into jeffh-fix-1546-second-key-extension
equalsJeffH ad71ff1
devicePublicKey extension section functionally complete
equalsJeffH 094d385
further edits...
equalsJeffH e66eb2d
cleanup trailing whitespace...
equalsJeffH 618b2de
Device-bound public key ProVerif model
equalsJeffH 1e97952
who-signs-what musings...
equalsJeffH 8f0d66d
editorial polishing
equalsJeffH 43e03c8
editorial polishing
equalsJeffH 503a027
major reorg & clarifications
equalsJeffH 87340d7
further reorg & polish
equalsJeffH cbb066f
proverif model cleanup
equalsJeffH 1e72a00
remove unused 'cert'
equalsJeffH 99a6b79
revise/correct objects hierarchy
equalsJeffH e9db523
clarifications
equalsJeffH 68ebaa2
clarifications
equalsJeffH 8b5702c
clarifications
equalsJeffH da82c2e
switch model starting-point to webauthn-basic.pv
equalsJeffH f84069b
clarifications
equalsJeffH f6663cb
clarifications to both DPK stuff and PV model
equalsJeffH 22e325d
revise model significantly
equalsJeffH a3ed05b
further clarifications and musings
equalsJeffH 6382444
editorial
equalsJeffH 768d900
revised dpk syntax per agl review
equalsJeffH fd9ea00
further refined dpk syntax per feedback
equalsJeffH a34b489
select the more simple AttObjForDevicePublicKey
equalsJeffH 2832b5e
begin reworking devicePubKey extension
equalsJeffH e47c5f8
editorial
equalsJeffH 75c8f25
device-bound-key-pair.pv -> device-bound-key-pair.txt
equalsJeffH 4515d63
add separate webauthn.pv file
equalsJeffH c208e19
editorial
equalsJeffH 591cded
Merge branch 'main' into jeffh-fix-1546-second-key-extension
equalsJeffH 59260f0
Merge branch 'main' into jeffh-fix-1546-second-key-extension
equalsJeffH c3487a2
fix attSecretKey in pv model
equalsJeffH 0e8d3b3
add README.pv.md file
equalsJeffH 6b216db
editorial cleanups
equalsJeffH 25b07e6
processUser -> processClientAndAuthnr
equalsJeffH 2da4504
define formal RegRequestMsg
equalsJeffH f943bbc
editorial
equalsJeffH e23ccfe
attPublicKey is public
equalsJeffH 7a1e2ee
WIP: refine attestation object construction
equalsJeffH 8a420eb
WIP: attObject parsing
equalsJeffH d2b529b
WIP: add Extensions.
equalsJeffH 666718a
editorial
equalsJeffH f9e861c
COMPLETED: refine attestation object construction
equalsJeffH e1a4383
refine events
equalsJeffH 9182fa1
editorial
equalsJeffH 89e2660
editorial
equalsJeffH 54eb767
more meaningful query wrt response msg.
equalsJeffH f6fcee8
add: set traceDisplay long
equalsJeffH 1747dff
fix var rebindings, trim queries
equalsJeffH 12ec079
update README.pv.md
equalsJeffH 59f2909
edit README.pv.md
equalsJeffH 8b4d51c
rename server name, plus other clieanups
equalsJeffH c5f3b2d
edit README.pv.md
equalsJeffH 4ebd028
remove pv files from this branch
equalsJeffH 4f18790
Merge branch 'main' into jeffh-fix-1658-device-bound-key-extension
equalsJeffH 66e67bd
update Device-bound public key extension
equalsJeffH 9ac274a
work in progress
equalsJeffH fcc6a68
finish Notes -- nominally complete for Draft PR
equalsJeffH 73cc7ff
Merge branch 'main' into jeffh-fix-1658-device-bound-key-extension
equalsJeffH 7c5393c
untraced device-bound-key-pair.txt
equalsJeffH 3d16662
context is now scope
equalsJeffH aee534c
do binary equality checks
equalsJeffH 7c3e2e8
Apply suggestions from emlun's code review, thanks!
equalsJeffH 90593b9
fixes inspired by emlun's review
equalsJeffH d0bef33
apply and merge emlun's review suggestions, thx!
equalsJeffH 89cec45
Merge branch 'main' into jeffh-fix-1658-device-bound-key-extension
equalsJeffH db63d69
incorp pascoej's correction, thx!
equalsJeffH 9a78683
fix bug emlun caught (thx) & apply polish
equalsJeffH d52342c
Apply emlun's suggestions, thx!
equalsJeffH e23c4b9
polish emlun's suggestion to not be a Note
equalsJeffH b8ec5b8
polish Authenticator extension processing
equalsJeffH 0bb9aaa
authnr extension rather than client extension
equalsJeffH 3237896
minor editorial fixes
equalsJeffH d652787
Merge branch 'main' into jeffh-fix-1658-device-bound-key-extension
equalsJeffH 55e64c9
revise intro and define most of verification procedure
equalsJeffH 41ffcbf
finish roughing-out verification procedures
equalsJeffH f131d68
remove extraneous Note on permissions policy that crept in somehow
equalsJeffH e1e6d94
incorp emlun's suggestion on hardware-bound device key pair definition
equalsJeffH 23ea3ef
add Notes to RP verification steps linking to DPK extension verificat…
equalsJeffH 683ad4d
do not use 'synced' user cred term per TimC
equalsJeffH 17f3aa2
update 'Relying Party Usage' section and note current issues
equalsJeffH b4e8d0e
clarification
equalsJeffH 619ebb9
wordsmithing, thx emlun!
equalsJeffH 2730294
incop & massage Emlun's suggestion, thx!
equalsJeffH f0fe8f2
rough WIP to fix issue #1701 side-channel attack
equalsJeffH f145234
further WIP re fixing #1701 authnr nonce, & noting #1711
equalsJeffH b8d8567
attempt at polishing various portions of devicePubKey
equalsJeffH d92bad2
The DPK is stored on the authenticator.
agl 6d45aba
Provide attestation controls.
agl eb598ff
Pull out DPK attestation rules and add signature prefix.
agl b7289e1
Reflow CDDL to avoid a scroll bar.
agl dcfb392
Have the DPK sign over everything.
agl cbb6b5d
Note that CTAP2 CBOR is required in DPK.
agl ccfd0b4
Resolve comment by jovasco
agl f3315b5
Merge branch 'main' into dpk
agl 27ef223
Link definitions from PR 1695.
agl bfce0cf
Make the DPK signature a different output field.
agl 20dd35c
Update attestation and add it for assertions
agl 27d0895
Introduce unsigned extension outputs and use it to return the dpk sig…
arnar e30cdb1
Fix build error
arnar 38fb4e1
Review fixes and another indentation fix
arnar 0c7fad0
Fix misplaced Note annotation
arnar 844cff7
Merge pull request #1754 from arnar/jeffh-fix-1658-device-bound-key-e…
agl 6fbfccf
Update attestation and add it for assertions
agl 4e67faa
Various fixes and updates in light of comments
agl 832c2e8
Merge branch 'main' into jeffh-fix-1658-device-bound-key-extension
emlun 6940a43
Merge pull request #1787 from w3c/merge-main-into-1658
agl 7b531a8
Apply more of emlun's suggestions from code review
agl 04ddb48
Apply one of emlun's suggestions
agl 3cba94c
Apply one of emlun's suggestions
agl 47017e4
Apply one of emlun's suggestions
agl 16a846a
Apply one of emlun's suggestions
agl 2ec8861
Apply one of emlun's suggestions
agl 5c1cd98
Apply suggestions from code review
agl 5c6c23d
Apply suggestions from code review
agl a026a5b
Apply one of emlun's suggestions
agl ec03d4d
Have the authenticator output a bytestring, not a map.
agl 88be1a6
Fix devicePubKey sub-heading levels
emlun 3430c95
Hopefully fix up my misinterpretation of emlun's comment.
agl 5af393d
RPs shouldn't check DPK attestation for equality.
agl fe333fe
Remove incorrect note about nonces.
agl ece61f0
Include enterpriseAttestationPossible when calling authenticatorGetAs…
agl 4279e6e
Apply one of emlun's suggestions
agl d25fd53
Mention where authData and hash are used.
agl 8966fe6
Apply emlun's suggestions from code review
agl d671894
Address emlun's comments.
agl ca1b0c6
Add a note to explain how the RP's challenge is included in dpkSig.
agl 6112877
Remove a horizontal scrollbar on the DPK CDDL.
agl ed0b779
Remove now superfluous variable in DPK processing.
agl 9bd0e3d
Apply Shane's suggestions
agl 759ce04
DPK is only valid for backup eligible credentials.
agl 8aa160c
Address Shane's comments.
agl bff403d
s/then/than, noticed by Shane.
agl fba2725
Add missing blank line. Thanks Emil.
agl f780870
Resolve last comment.
agl 6ae32a0
Merge branch 'main' into dpk
agl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.