-
Notifications
You must be signed in to change notification settings - Fork 43
Add immediate mediation #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A few comments.
@marcoscaceres, could you take a look as well? Thanks! |
|
||
Websites can optionally request the {{PasswordCredential}} credential type in addition to the {{PublicKeyCredential}} credential type. | ||
|
||
{{CredentialMediationRequirement/immediate}} is ignored for {{CredentialsContainer/create()}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in the create() algorithm, not here IMO. (or if it is, this then this doesn't need to be here)
|
||
: <dfn>immediate</dfn> | ||
:: The user agent will not hand over credentials without [=user mediation=]. | ||
If the user agent determines a lack of applicable credentials, the user agent will throw a "{{NotAllowedError}}" {{DOMException}} without [=user mediation=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, this needs to be in an algorithm or more explicitly linked to an algorithm.
This PR adds a new enumeration value to
CredentialMediationRequirement
, corresponding to the immediate mediation proposal described in a WebAuthn explainer.The WebAuthn issue: w3c/webauthn#2228
A WebAuthn PR will follow that references this mediation value.
Preview | Diff