-
Notifications
You must be signed in to change notification settings - Fork 20
Added changes to the vocabulary per #158 #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note to myself/ourselves: if this PR is approved in such a way that the "statusReference": "https://www.w3.org/ns/credentials/status#statusReference",
"statusSize": "https://www.w3.org/ns/credentials/status#statusSize", this should be changed to "statusReference" : {
"@id" : "https://www.w3.org/ns/credentials/status#statusReference",
"@type" : "@id"
},
"statusSize": {
"@id" : "https://www.w3.org/ns/credentials/status#statusSize",
"@type": "https://www.w3.org/2001/XMLSchema#positiveInteger"
} |
This comment was marked as resolved.
This comment was marked as resolved.
The specification says:
I am just a go-between 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking me to review this. I'm glad you did as this looks super-interesting but I admit it's the first I've seen of it. Therefore, I am not in a position to say yay or nay - except that what Ivan has proposed certainly seems to make sense.
The issue was discussed in a meeting on 2024-04-03
View the transcript3.5. Added changes to the vocabulary per #158 (pr vc-bitstring-status-list#159)See github pull request vc-bitstring-status-list#159. Ivan Herman: there is one PR #159 which has to be done before CR.
Gabe Cohen: not to folks, please review 159.
Gabe Cohen: that wraps up the schedule. any other items. |
Editorial, multiple positive reviews, questions asked were answered, no changes requested, no objections, merging. |
This PR implements the extra changes as described in w3c/vc-bitstring-status-list#159 (comment), now that w3c/vc-bitstring-status-list#159 has been merged.
For the record, w3c/vc-data-model#1471 has been raised to complete the changes described in #159 (comment). |
This PR implements the extra changes as described in w3c/vc-bitstring-status-list#159 (comment), now that w3c/vc-bitstring-status-list#159 has been merged.
This PR implements the extra changes as described in w3c/vc-bitstring-status-list#159 (comment), now that w3c/vc-bitstring-status-list#159 has been merged.
This PR implements the changes proposed in #158, adds a diagram (with its textual description) to the generated HTML+RDFa file to be in line in style with the other vocabularies.
As usual, the built-in preview would not help for the generated vocabulary files and the diagrams. The preview page to be used is here: https://w3c.github.io/yml2vocab/previews/sl/