Skip to content

Added changes to the vocabulary per #158 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

iherman
Copy link
Member

@iherman iherman commented Mar 29, 2024

This PR implements the changes proposed in #158, adds a diagram (with its textual description) to the generated HTML+RDFa file to be in line in style with the other vocabularies.

As usual, the built-in preview would not help for the generated vocabulary files and the diagrams. The preview page to be used is here: https://w3c.github.io/yml2vocab/previews/sl/

@iherman iherman requested review from dlongley and TallTed March 29, 2024 09:41
@iherman iherman added the before-CR This issue needs to be resolved before the Candidate Recommendation phase. label Mar 29, 2024
@iherman
Copy link
Member Author

iherman commented Mar 30, 2024

Note to myself/ourselves: if this PR is approved in such a way that the xsd:positiveInteger is used as the range of statusSize, then the crdential context file must be updated as well. At the moment, it says (in line 214-215)

        "statusReference": "https://www.w3.org/ns/credentials/status#statusReference",
        "statusSize": "https://www.w3.org/ns/credentials/status#statusSize",

this should be changed to

    "statusReference"  : {
       "@id" : "https://www.w3.org/ns/credentials/status#statusReference",
       "@type" : "@id"
    },
    "statusSize": {
       "@id" : "https://www.w3.org/ns/credentials/status#statusSize",
       "@type": "https://www.w3.org/2001/XMLSchema#positiveInteger"
    }

cc @dlongley @msporny @davidlehn

@TallTed

This comment was marked as resolved.

@iherman
Copy link
Member Author

iherman commented Apr 2, 2024

Would xsd:nonNegativeInteger be more appropriate than xsd:positiveInteger, i.e., could the value of statusSize ever be 0?

The specification says:

If statusSize is not present as a property of the credentialStatus, then statusSize MUST be processed as 1. statusSize MUST be an integer greater than zero.

I am just a go-between 😀

Copy link

@philarcher philarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking me to review this. I'm glad you did as this looks super-interesting but I admit it's the first I've seen of it. Therefore, I am not in a position to say yay or nay - except that what Ivan has proposed certainly seems to make sense.

@iherman
Copy link
Member Author

iherman commented Apr 3, 2024

The issue was discussed in a meeting on 2024-04-03

  • no resolutions were taken
View the transcript

3.5. Added changes to the vocabulary per #158 (pr vc-bitstring-status-list#159)

See github pull request vc-bitstring-status-list#159.

Ivan Herman: there is one PR #159 which has to be done before CR.
… this is related to mechanics of the repository.
… the vocab is wrong, we have to change the context file, ... there are some changes we need to get in before CR.

Manu Sporny: +1 to making the changes Ivan is suggesting :).

Gabe Cohen: not to folks, please review 159.

Manu Sporny: You have 4 positive reviews now, Ivan. :).

Gabe Cohen: that wraps up the schedule. any other items.
… that's a wrap. Please review the issues, especially on bitstring status list and VCDM.
… next week VC-JOSE-COSE considered for CR.


@msporny
Copy link
Member

msporny commented Apr 6, 2024

Editorial, multiple positive reviews, questions asked were answered, no changes requested, no objections, merging.

@msporny msporny merged commit b108b04 into main Apr 6, 2024
2 checks passed
@msporny msporny deleted the improve-vocabulary branch April 6, 2024 18:01
iherman added a commit to w3c/vc-data-model that referenced this pull request Apr 7, 2024
This PR implements the extra changes as described in w3c/vc-bitstring-status-list#159 (comment), now that w3c/vc-bitstring-status-list#159 has been merged.
@iherman
Copy link
Member Author

iherman commented Apr 7, 2024

For the record, w3c/vc-data-model#1471 has been raised to complete the changes described in #159 (comment).

msporny pushed a commit to w3c/vc-data-model that referenced this pull request Apr 16, 2024
This PR implements the extra changes as described in w3c/vc-bitstring-status-list#159 (comment), now that w3c/vc-bitstring-status-list#159 has been merged.
msporny pushed a commit to w3c/vc-data-model that referenced this pull request May 26, 2024
This PR implements the extra changes as described in w3c/vc-bitstring-status-list#159 (comment), now that w3c/vc-bitstring-status-list#159 has been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants