Skip to content

Proposed implementation of #106 #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Conversation

maximelefrancois86
Copy link
Contributor

@maximelefrancois86 maximelefrancois86 commented Nov 30, 2023

As part of our work at ETSI on the development of a new version of SAREF, we reached last week an agreement on how to solve this issue.

Note that this is a compromise that resolves a six year long dispute between two former contributors to SOSA/SSN 😉, so I hope it will be well received by the group.

@dr-shorthair dr-shorthair self-requested a review December 3, 2023 21:47
@dr-shorthair
Copy link
Collaborator

dr-shorthair commented Dec 7, 2023

Also see #49 and #52

Closes #106

Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label of PropertyOfInterest is just "Property"

is there a need for a PropertyKind as well for symmetry to allow for more general classifications? And potentially a constraint for ObservationCollections that observedProperty objects are some form of specialisation of PropertyKind? Is there an equivalent constraint for Property w.r.t to PropertyOfInterest ?

also we have identified 3 possible profiles for observedProperty depending on which case - is the range of observedProperty a union of these options or do we need more predicates?

examples are critical here me feels..

@maximelefrancois86
Copy link
Contributor Author

@rob-metalinkage I fixed the nit in latest commit on this branch.

If in addition to "PropertyOfInterest" you believe we would need a third class named "PropertyKind", I suggest you approve this PR first, then we could discuss that need.

I intentionally left out any modification of the ranges of object properties, to proceed incrementally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants