Skip to content

editorial: fix 2 links to dpub-aria #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

editorial: fix 2 links to dpub-aria #2492

merged 2 commits into from
Mar 27, 2025

Conversation

pkra
Copy link
Member

@pkra pkra commented Mar 25, 2025

Looks like old copy & paste errors.


Preview | Diff

@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit dd2f6ab
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67e2da40569f300008c72641
😎 Deploy Preview https://deploy-preview-2492--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkra pkra requested a review from daniel-montalvo March 25, 2025 16:30
Copy link
Contributor

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkra for catching those. I just wonder if we could put the changes to index.html on a separate PR if they don't have to do with dpub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this relate to dpub?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's from prettier -- cf. #2470

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @pkra I put the comment on the wrong file. This one seems to also be from prettier right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Yes, it's from prettier.

@pkra pkra merged commit 648b1a4 into main Mar 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:dpub-aam
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants