-
Notifications
You must be signed in to change notification settings - Fork 133
[core-aam PR 230] Update aria-labelledby AXAPI mapping to use AXTitle #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Include co-author when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rahim, this PRs has been moved, so please continue the work here :)
I have a few questions/comments for you:
- This looks good, but from the issue, it looks like
aria-label
is updated toAXTitle
as well, where you doing that in a separate PR? Seems to me like it could be done here as well. - Can you confirm whether there will need to be a change in firefox and chrome? Seems like it! if so we need to track those implementations.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello @spectranaut!
Agreed (thank you), I've updated the PR to include both
No change is required for implementations, so related API tests should be crafted to allow either attribute. Although |
@spectranaut May we close this PR out if you have no further concerns? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
I just want to give the chance for you to ack or make a change re: James request.
Also, about this:
- Can you confirm whether there will need to be a change in firefox and chrome? Seems like it! if so we need to track those implementations.
No change is required for implementations, so related API tests should be crafted to allow either attribute. Although
AXTitle
is now the recommended AXAPI mapping foraria-label
/aria-labelledby
, engines may still use the legacyAXDescription
attribute. James and I do not believe the older alternative needs to be documented by an evergreen spec.
Interesting point... it still seems like browser ought to know about the change, an issue on the browser could say "the old way is support, but btw, you don't need to maintain that logic to separately exposing things in either AXDescription or AXTitle.
I'll make an issue on browsers when this change lands.
Does VoiceOver and friends still make a distinction between AXTitle and AXDescription? Is this change already in Safari? Trying to gauge how safe it is to throw out AXDescription in Firefox since it is a headache and something we don't want to invest more time in. |
@eeejay VO Eng manager confirmed it's fine to use |
@cookiecrook thanks. How far back has this been true in VO? Are there versions still in use that require AXDescription? |
Copies w3c/core-aam#230 by @rahimabdi
Closes w3c/core-aam#215
Browser bugs: