Skip to content

Editorial: Clarify aria-expanded guidance #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 24, 2025
Merged

Editorial: Clarify aria-expanded guidance #1980

merged 11 commits into from
Apr 24, 2025

Conversation

adampage
Copy link
Member

@adampage adampage commented Jul 11, 2023 •
edited by pr-preview bot
Loading

Closes #1912

Clarifies authoring guidance for aria-expanded by discouraging ownership of the controlled grouping element except in the cases of treeitem and row.

Preview | Diff

@adampage adampage self-assigned this Jul 11, 2023
@pkra pkra added this to the ARIA 1.3 milestone Jul 13, 2023
@pkra pkra added the clarification clarifying or correcting language that is either confusing, misleading or under-specified label Jul 13, 2023
@adampage
Copy link
Member Author

Hey @scottaohara, how about this second revision?

In anticipation of #1965, I went ahead and killed off the “ownership” terminology and used accessibility parent instead.

scottaohara
scottaohara reviewed Aug 17, 2023
View reviewed changes
scottaohara
scottaohara reviewed Aug 17, 2023
View reviewed changes
scottaohara
scottaohara reviewed Aug 17, 2023
View reviewed changes
adampage and others added 4 commits August 23, 2023 11:46
@adampage @scottaohara
Update index.html
c8b956f 
Co-authored-by: Scott O'Hara <[email protected]>
@adampage @scottaohara
Update index.html
7cdaefc 
Co-authored-by: Scott O'Hara <[email protected]>
@adampage @scottaohara
Update index.html
aa593ed 
Co-authored-by: Scott O'Hara <[email protected]>
@adampage
add example markup
220d8b6
@adampage
Copy link
Member Author

Thanks for the code suggestions and feedback, @scottaohara. 🙏🏻 I’ve added two markup examples to help illustrate the differences.

@adampage adampage requested a review from scottaohara August 23, 2023 19:19
scottaohara
scottaohara approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just one wording suggestion.

@spectranaut spectranaut changed the title Clarify aria-expanded guidance Editorial: Clarify aria-expanded guidance May 2, 2024
@jnurthen jnurthen requested a review from aardrian May 2, 2024 20:57
@jnurthen
Copy link
Member

jnurthen commented May 2, 2024

@aardrian this was lacking a 3rd reviewer. Would you be able to take a look?

@jnurthen
Copy link
Member

jnurthen commented May 2, 2024

@curtbellew can you please review this - we would like to get it merged. Thanks.

@pkra pkra added the spec:aria label Jun 14, 2024
@spectranaut spectranaut self-requested a review March 25, 2025 17:26
spectranaut
spectranaut approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, James and I just took a look.

@scottaohara
Copy link
Member

does that count as one or two reviews, then? ;)

@spectranaut
Copy link
Contributor

does that count as one or two reviews, then? ;)

2! :)

Just waiting for Adam to fix the merge conflicts -- it might be easiest to copy out the text of your changes, update the file to match main, then reapply your changes by hand.... or open a new PR? What ever is easiest for you.

@netlify Netlify
Copy link

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit a3dc437
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/680706ab02cc8c00082b54bd
😎 Deploy Preview https://deploy-preview-1980--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adampage
Copy link
Member Author

Just waiting for Adam to fix the merge conflicts

Fixed! 🤞🏻🚀 cc: @spectranaut

@adampage adampage requested a review from spectranaut April 22, 2025 03:02
@spectranaut spectranaut merged commit 44ffc4d into w3c:main Apr 24, 2025
7 checks passed
github-actions bot added a commit that referenced this pull request Apr 24, 2025
@adampage @github-actions
Editorial: Clarify aria-expanded guidance (#1980)
10e0c07 
SHA: 44ffc4d
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to adampage/aria that referenced this pull request Apr 28, 2025
@adampage @github-actions
Editorial: Clarify aria-expanded guidance (w3c#1980)
b3577ed 
SHA: 44ffc4d
Reason: push, by adampage

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 29, 2025
@adampage @github-actions
Editorial: Clarify aria-expanded guidance (#1980)
a445821 
SHA: 44ffc4d
Reason: push, by spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut spectranaut approved these changes

@scottaohara scottaohara scottaohara approved these changes

@curtbellew curtbellew Awaiting requested review from curtbellew

@aardrian aardrian Awaiting requested review from aardrian

Assignees

@adampage adampage

Labels
clarification clarifying or correcting language that is either confusing, misleading or under-specified spec:aria
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

Minor clarification for aria-expanded
5 participants
@adampage @jnurthen @scottaohara @spectranaut @pkra