Infrastructure: Control pages read-this-first.html appears on from APG
#3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
added
the
Infrastructure
howard-e
changed the title
read-this-first.html appears from APGread-this-first.html appears on from APG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3293
Additionally, this PR ensures the pages that
/content/shared/templates/read-this-first.htmlappears on is controlled from this repository with the new/shared/js/read-this-first.jsscript. That was being done fromw3c/wai-aria-practicesby manually adding the template into the patterns and practices index pages. This was discussed in Jul 22, 2025 TF meeting.The script is doing the same by inserting the template content after the first
h1found on the page.This PR means the insertion from
w3c/wai-aria-practicesshould be removed. Note that this should be reviewed and merged before w3c/wai-aria-practices#422 is merged.WAI Preview Link (Last built on Wed, 30 Jul 2025 18:52:36 GMT).