Fix: Ensure timingInfo is returned on network fallback if SW static routing API is used #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quasi-mod I also found that "network" should be set if "fetch-event" is a matched router source, and fallback according to the explainer. Let me revise the algorithm like so. |
quasi-mod
approved these changes
May 30, 2025
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
May 30, 2025
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the explainer, the
worker final router sourceshould be'network'for a network fallback. The |timingInfo| is returned to make that happen.Preview | Diff