Skip to content

Fix: Correct return type and preserve response timing info #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

yoshisatoyanagisawa
Copy link
Collaborator

@yoshisatoyanagisawa yoshisatoyanagisawa commented May 30, 2025

This pull request introduces the following enhancements:

  1. Type Correction for race-network-and-fetch-event: Modified the race-network-and-fetch-event algorithm to consistently return the correct value type. This addresses a previous inconsistency where the algorithm could yield a value of a different, incorrect type.
  2. Preservation of Response Timing Information: Ensured that timing information within the response, particularly the fetch event dispatch time, is retained when the fetch event's value is utilized. This resolves an issue where such timing data was previously being discarded.

Preview | Diff

Adjust the variables in race-network-and-fetch-handler algorithm to
point the proper data.
@yoshisatoyanagisawa
Copy link
Collaborator Author

@quasi-mod Sorry for overlooking them in your previous pull request. Let me fix.

@quasi-mod
Copy link
Contributor

Oops, thanks for fixing! LGTM.

@yoshisatoyanagisawa yoshisatoyanagisawa merged commit 2c732f5 into w3c:main May 30, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request May 30, 2025
SHA: 2c732f5
Reason: push, by yoshisatoyanagisawa

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to yoshisatoyanagisawa/ServiceWorker that referenced this pull request May 30, 2025
SHA: 2c732f5
Reason: push, by yoshisatoyanagisawa

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request May 30, 2025
SHA: 2c732f5
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yoshisatoyanagisawa yoshisatoyanagisawa deleted the race_fix branch May 30, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants