Update Handle Fetch to return timing info #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes the Handle Fetch algorithm to propagate timingInfo even when are fallback to the network (i.e. Handle Fetch will return NULL). |
|
@yoshisatoyanagisawa @domenic , Could you take a look and see if this is OK? |
|
lgtm |
yoshisatoyanagisawa
approved these changes
May 29, 2025
|
Thanks, here is an ongoing change (not a PR yet, since we do not have the signal from other vendors yet) https://github.com/quasi-mod/fetch/tree/resource-timing/01/expose-service-worker-timing |
|
Thanks for the link, the new return value makes sense to me. |
github-actions bot
added a commit
that referenced
this pull request
May 29, 2025
SHA: 4e9d705 Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
May 29, 2025
SHA: 4e9d705 Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff