-
-
Notifications
You must be signed in to change notification settings - Fork 8
refactor(config): restructure eslint configuration and build setup #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved eslint configuration to a function - Added new config files for various linting rules (js, ts, vue, etc.) - Updated build configuration to use unbuild - Removed deprecated eslint config files and utilities - Added type generation script for linting rules - Updated package.json to reflect new build and type generation setup
Add badges for npm version, downloads, and license. Update install instructions to include npm, yarn, pnpm, bun, and deno. Enhance usage section with detailed examples and customization options. Add contributors section with community recognition.
Remove redundant code blocks and consolidate package manager install commands into a single block for better readability and maintainability.
The previous logic incorrectly checked if `options.import` and `options.export` were `true` to enable rules. This has been updated to check if they are not `false` instead, ensuring the rules are enabled by default unless explicitly disabled
This change ensures consistency across schema objects by making the `files` field optional. This improves flexibility and reduces unnecessary boilerplate when configuring these schemas.
Ensure config functions handle cases where `options.files` is undefined by adding a check. This prevents potential runtime errors when `options` is an object but lacks the `files` property.
- Modify `assertPackage` to handle missing dependencies interactively - Update `package.json` dependencies to latest versions - Add new dependencies for improved CLI prompts and package management
johnleider
reviewed
Apr 23, 2025
johnleider
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot to consume, but on the surface, the code looks good.
The import and function name `withConfig` in docs/tests/usage was renamed to `vuetify`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.