Skip to content

refactor(config): restructure eslint configuration and build setup #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 24, 2025

Conversation

AndreyYolkin
Copy link
Contributor

@AndreyYolkin AndreyYolkin commented Apr 19, 2025

  • Moved eslint configuration to a function
  • Added new config files for various linting rules (js, ts, vue, etc.)
  • Updated build configuration to use unbuild
  • Removed deprecated eslint config files and utilities
  • Added type generation script for linting rules
  • Updated package.json to reflect new build and type generation setup
  • Added tests

- Moved eslint configuration to a function
- Added new config files for various linting rules (js, ts, vue, etc.)
- Updated build configuration to use unbuild
- Removed deprecated eslint config files and utilities
- Added type generation script for linting rules
- Updated package.json to reflect new build and type generation setup
Add badges for npm version, downloads, and license. Update install instructions to include npm, yarn, pnpm, bun, and deno. Enhance usage section with detailed examples and customization options. Add contributors section with community recognition.
@AndreyYolkin AndreyYolkin self-assigned this Apr 19, 2025
Remove redundant code blocks and consolidate package manager install commands into a single block for better readability and maintainability.
The previous logic incorrectly checked if `options.import` and `options.export` were `true` to enable rules. This has been updated to check if they are not `false` instead, ensuring the rules are enabled by default unless explicitly disabled
This change ensures consistency across schema objects by making the `files` field optional. This improves flexibility and reduces unnecessary boilerplate when configuring these schemas.
Ensure config functions handle cases where `options.files` is undefined by adding a check. This prevents potential runtime errors when `options` is an object but lacks the `files` property.
@AndreyYolkin AndreyYolkin marked this pull request as ready for review April 21, 2025 18:11
@AndreyYolkin AndreyYolkin requested a review from johnleider April 21, 2025 18:11
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot to consume, but on the surface, the code looks good.

The import and function name `withConfig` in docs/tests/usage was renamed to `vuetify`
@AndreyYolkin AndreyYolkin merged commit 678af17 into master Apr 24, 2025
@AndreyYolkin AndreyYolkin deleted the v4 branch April 24, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants