Refactor to setupConfigure for #2388

[yoyo930021]

Fixed #2388

It also conveniently fixes a problem where incorrect settings could be imported.

[octref]

LGTM 👍

[rchl]

I'd like to better understand the changes done here to fix it properly in #2436.

Why was it not enough to run setupDynamicFormatters() from onDidChangeConfiguration notification?

Sending it when handling the initialize request, as done here, is too early.

We could send it from initialized but I'm not sure why from onDidChangeConfiguration() was not enough since the client is pretty much guaranteed to send it early after initialize.

Was the problem more related to passing a partial config to setupDynamicFormatters?

[yoyo930021]

I'd like to better understand the changes done here to fix it properly in #2436.

Why was it not enough to run setupDynamicFormatters() from onDidChangeConfiguration notification?

Sending it when handling the initialize request, as done here, is too early.

We could send it from initialized but I'm not sure why from onDidChangeConfiguration() was not enough since the client is pretty much guaranteed to send it early after initialize.

Was the problem more related to passing a partial config to setupDynamicFormatters?

I think it's a try.
My first suspicion was that it wouldn't be triggered onDidChangeConfiguration on startup.
I guess we could rollup back this part.

[rchl]

OK, good. That means I can probably safely revert that logic. Thanks.