Support optional deprecated when completion #2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
changed the title
yoyo930021
force-pushed
the
fix-optional-chaining
branch
2 times, most recently
from
3d29453 to
a7372e0
Compare
octref
reviewed
Oct 29, 2020
| kind: toCompletionItemKind(entry.kind), | ||
| textEdit: range && TextEdit.replace(range, entry.name), | ||
| kind: kinds.color ? CompletionItemKind.Color : toCompletionItemKind(entry.kind), | ||
| textEdit: range && TextEdit.replace(range, entry.insertText || entry.name), |
There was a problem hiding this comment.
Let's mostly follow VS Code's source code's logic, so in the future it's easy to update.
Besides, there's too many condition in a single statement so we should simplify it.
octref
approved these changes
Oct 29, 2020
octref
force-pushed
the
fix-optional-chaining
branch
from
a7372e0 to
5166dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2326