Fix corner case and add v-model support when prop validation #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
changed the title
yoyo930021
force-pushed
the
fix-props-validator
branch
2 times, most recently
from
1bc21df to
6de96f9
Compare
octref
force-pushed
the
fix-props-validator
branch
from
6de96f9 to
cd25383
Compare
octref
requested changes
Sep 6, 2020
octref
reviewed
Sep 6, 2020
| normalized: normalizeHtmlAttributeNameToKebabCase(attr) | ||
| normalized: normalizeHtmlAttributeNameToKebabCase( | ||
| attr, | ||
| definedProps.find(prop => prop.defaultModel)?.name ?? 'value' |
There was a problem hiding this comment.
I would write my logic here:
- If it's
v-model, create a function such asnormalizeModelAttrthat takes in thedefinedPropsand find it's normalized prop. You can make this function usenormalizeHtmlAttributeNameToKebabCase. - If it's not, use
normalizeHtmlAttributeNameToKebabCasedirectly
Currently this function is overloaded with too many things. Make one function do one thing is better (and then compose them).
There was a problem hiding this comment.
I hesitated when I wrote this function,
but I'm writing this anyway.
I will send a PR to refactor it.
octref
requested changes
Sep 6, 2020
octref
force-pushed
the
fix-props-validator
branch
from
3e05152 to
18ba3e9
Compare
|
Sorry I didn't wait. I'm planning to make a release soon to address the folidng issue and this issue, so I made the changes myself. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2236
Fixed #2237