Fix template interpolation in vfor when readonly array #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
changed the title
ktsn
reviewed
Mar 16, 2020
| @@ -29,6 +29,7 @@ export declare const ${componentHelperName}: { | |||
| }; | |||
| export declare const ${iterationHelperName}: { | |||
| <T>(list: T[], fn: (value: T, index: number) => any): any; | |||
| <T>(list: readonly T[], fn: (value: T, index: number) => any): any; | |||
There was a problem hiding this comment.
I believe just changing existing T[] overload is enough rather than adding a new one.
There was a problem hiding this comment.
I change T[] to readonly T[] | T[].
There was a problem hiding this comment.
I mean just changing it to readonly T[] because it's super type of T[]
yoyo930021
force-pushed
the
fix-readonly-array-in-vfor
branch
from
0b9202f to
0f83ba9
Compare
yoyo930021
force-pushed
the
fix-readonly-array-in-vfor
branch
from
0f83ba9 to
fe0e845
Compare
ktsn
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When array is readonly, I will get
anyinv-forelement.