Avoid virtual template code is broken when attribute name has hyphen #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, CI is failing. I'll investigate it. |
|
That's weird. Auto complete test passes on my local 🤔 |
octref
approved these changes
Apr 24, 2019
|
When that many tests fail it's probably because VLS crashed. All tests passing on my local machine too though so I'm merging this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a template includes some attribute having hyphen on its name, the virtual Vue template will be broken and provides numerous errors. This is because the transformer try to generate the attribute name as identifier even though hyphen is invalid character as identifier.
I've simply changed them to string literal to accept hyphen.