Skip to content

fix(runtime-core): hydration should not be performed during the HMR reload process(fix #7706) #8170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Jevon617
Copy link

Close #7706.

During HMR reload, the div element is unmounted. However, in SSR mode, the mountComponent process does not remount the div element but hydrates it instead, causing the issue of the div element is deleted.

@edison1105
Copy link
Member

edison1105 commented Oct 28, 2024

Thank you for your contribution! We have created a new PR to resolve issue #7706, making this PR redundant. Additionally, this PR contains incorrect modifications and lacks necessary test cases. Thank you for your understanding!

@edison1105 edison1105 closed this Oct 28, 2024
edison1105 added a commit that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

HMR not working after failed hydration
2 participants