Skip to content

don't raise exceptions due normal usage #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galkinvv
Copy link

  1. Don't raise while filling initial results into extracted category:
    the old code added 'undefined' object
    as initial single element in TMNQueries.extracted,
    and this randomly lead to problems,
    especially if actual results were not extracted
    (for example non-latin results only)

  2. Don't produce network errors on Validate button
    (split feeds by | like in apply)

  3. Don't raise errors on custom mostly non-latin-alphabet feeds:
    if feed returns only spaces - don't add it.

This should help #111

Tested on chrome 77.

1. Don't raise while filling initial results into extracted category:
the old code added 'undefined' object
as initial single element in TMNQueries.extracted,
and this randomly lead to problems,
especially if actual results were not extracted
(for example non-latin results only)

2. Don't produce network errors on Validate button
(split feeds by | like in apply)


3. Don't raise errors  on mostly non-latin-alphabet feeds:
if feed returns only spaces - don't add it.


Tested on chrome 77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant