Improve args handling #61
Conversation
| ^^^ | ||
| source.hx meta.method.hx meta.parameters.hx support.class.builtin.hx | ||
| ^ | ||
| source.hx meta.method.hx meta.parameters.hx |
There was a problem hiding this comment.
should be a "comma", or is that what the other PR fixes?
there are some more places where it fails to detect a comma, it'll be easier to spot once the source is converted from tabs.
There was a problem hiding this comment.
Yep, there is still a lot of skipped commas it seems, but it was like this before too? At least coloring is much better.
There is still one broken case in test:
var a = (
a:Int,
b:Int, // bad b color, () is detected as block instead of arrow
) -> 0;Do i need to remove it and move to separate issue for now?
There was a problem hiding this comment.
I agree, colors are less broken than before :)
I think it's fine to split them off into different issues, unless you want to have a go and try to fix trailing commas and arrow args before merging.
There was a problem hiding this comment.
Not this time, just tried it a bit and still cannot understand why multiline arrows is not handled
There was a problem hiding this comment.
then we'll have to keep #57 open for now.
|
feel free to merge when ready |
This also generates
punctuation.separator.comma.hxtag between function argsSee #57
Closes #39