-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Allow options in objectToDocumentXML when calling a method #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ndeniche please add more tests to cover all scenarios. |
i'm closing this in 4 days if there's no more action |
All of my new code is covered. Should I improve coverage by adding tests to other features? |
@ndeniche if coverage has decreased, then not all the added code has been covered. |
@w666 -- can the current, up-to-date, checks be re-ran on this since coveralls was removed? |
@smokhov I don't have access to coveralls, project was not properly maintained for some time. |
f261f01
to
cb1de16
Compare
Okay, rebased that one, it works. I will have another look before next release. Thanks for help. |
* Options is optional field for objectToDocumentXML function * Replicates `_xml` parameter functionality (sending a custom XML structure as a literal) with JSON arguments.
cb1de16
to
3a38e86
Compare
Nah, can't approve this, test does not work, test still pass even when I set PR goes to backlog for now. |
Allows overriding the InputMessage "Request" element for custom elements based on args param
objectToDocumentXML
function_xml
parameter functionality (sending a custom XML structure as a literal) with JSON arguments.