Skip to content

Add additional extension URI to Arrow Substrait Compiler #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Nov 24, 2022
Merged

Add additional extension URI to Arrow Substrait Compiler #208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
5265001
Update compiler superclass to take a list of extension URIs
thisisnic Nov 15, 2022
0347e2c
Update Arrow compiler to extract out the function name properly
thisisnic Nov 15, 2022
edf86fd
Don't run tests on Arrow that won't run on Arrow
thisisnic Nov 15, 2022
98ae9a3
Implement greater than in Arrow and unskip a test to show it works
thisisnic Nov 15, 2022
fddd210
Update R/pkg-arrow.R
thisisnic Nov 15, 2022
82b252f
Update R/pkg-arrow.R
thisisnic Nov 15, 2022
51428fd
Shortern names at end
thisisnic Nov 16, 2022
fb0a469
maybe generate the correct plan
paleolimbot Nov 16, 2022
c6c6161
Simplify test and extend test to check output
thisisnic Nov 16, 2022
88410cf
Update test to reference correct object
thisisnic Nov 16, 2022
8cc00c8
Fix typo
thisisnic Nov 16, 2022
d77cb70
Skip if we don't have Arrow+Substrait installed
thisisnic Nov 17, 2022
486b0bb
Re-enable building Arrow
thisisnic Nov 17, 2022
07159c5
Remove library call here
thisisnic Nov 17, 2022
468c4e6
Try installing substrait to different dir
thisisnic Nov 21, 2022
4a46a66
Point to the relevant dir for deps
thisisnic Nov 21, 2022
9a54d9a
Attempt with DuckDB 0.6.0
thisisnic Nov 22, 2022
d317c83
Install from duckdb not CRAN
thisisnic Nov 22, 2022
42e67da
Fix typo
thisisnic Nov 22, 2022
3cbcccf
Reorder CI jobs to speed up CI testing
thisisnic Nov 22, 2022
f054070
Add 'v' to version
thisisnic Nov 22, 2022
d24b941
Change version to 0.5.1 to avoid infinite loop when installing
thisisnic Nov 22, 2022
b396230
Use CRAN version
thisisnic Nov 22, 2022
9f693ed
6
thisisnic Nov 22, 2022
fe05e8c
try duckdb 0.5.0
paleolimbot Nov 22, 2022
64358c7
Skip DuckDb tests if no duckdb with substrait
thisisnic Nov 23, 2022
63e8d91
Document missing R6 method
thisisnic Nov 23, 2022
bae2720
Merge branch 'extension-uri' of github.com:thisisnic/substrait-r into…
thisisnic Nov 23, 2022
5224683
Skip if no duckdb with substrait
thisisnic Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions man/SubstraitCompiler.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions tests/testthat/test-pkg-arrow.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
library(arrow, warn.conflicts = FALSE)
skip_if_not(has_arrow_with_substrait())

test_that("ArrowSubstraitCompiler$plan() generates the correct extension URIs", {
df <- tibble::tibble(x = 1:3)
Expand Down