added necessary packages

[Shrutim1505]

Dashboard was failing to resolve necessary imports.

Fixed error by adding necessary packages.

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Shrutim1505]

/assign @william-wang

[Shrutim1505]

hi @Monokaix u can merge this one to resolve unnecessay conflicts while running

[karanBRAVO]

Hello @Shrutim1505,
These changes are good, but you should add these in their respected workspace, like in this you should add them in frontend workspace.

npm i <package_name> -w frontend

One more thing I want to say is about your commit message, you should not use ed in add.

add necessary packages

[Monokaix]

Hello @Shrutim1505, These changes are good, but you should add these in their respected workspace, like in this you should add them in frontend workspace.

npm i <package_name> -w frontend

One more thing I want to say is about your commit message, you should not use ed in add.

add necessary packages

You mean add a ci for build check? just as what #37 is doing.

[karanBRAVO]

Hello @Shrutim1505, These changes are good, but you should add these in their respected workspace, like in this you should add them in frontend workspace.

npm i <package_name> -w frontend

One more thing I want to say is about your commit message, you should not use ed in add.

add necessary packages

You mean add a ci for build check? just as what #37 is doing.

I mean to say that like there is a separate package.json file for every workspace frontend and backend and one which is in the root (which define these workspaces). The packages related to frontend should be listed in frontend workspace and so on.

And for the commit message, we can add a commit linter like https://commitlint.js.org/, so that everyone follow same convention while writing commit messages. We can create issue related to this.

[Monokaix]

Hello @Shrutim1505, These changes are good, but you should add these in their respected workspace, like in this you should add them in frontend workspace.

npm i <package_name> -w frontend

One more thing I want to say is about your commit message, you should not use ed in add.

add necessary packages

You mean add a ci for build check? just as what #37 is doing.

I mean to say that like there is a separate package.json file for every workspace frontend and backend and one which is in the root (which define these workspaces). The packages related to frontend should be listed in frontend workspace and so on.

And for the commit message, we can add a commit linter like https://commitlint.js.org/, so that everyone follow same convention while writing commit messages. We can create issue related to this.

It makes sense.

[Monokaix]

Hello @Shrutim1505, These changes are good, but you should add these in their respected workspace, like in this you should add them in frontend workspace.

npm i <package_name> -w frontend

One more thing I want to say is about your commit message, you should not use ed in add.

add necessary packages

You mean add a ci for build check? just as what #37 is doing.

I mean to say that like there is a separate package.json file for every workspace frontend and backend and one which is in the root (which define these workspaces). The packages related to frontend should be listed in frontend workspace and so on.
And for the commit message, we can add a commit linter like https://commitlint.js.org/, so that everyone follow same convention while writing commit messages. We can create issue related to this.

It makes sense.

But I think maybe we can solve this completely after #37 merged.

[Shrutim1505]

Hi @Monokaix @karanBRAVO These imports are essential for the existing frontend because, after each pull, we need to resolve issues related to missing necessary imports.
Yeah sure we could solve this one after #37

[karanBRAVO]

Yes you are right but for consistency in the codebase I was suggesting the changes :)

[Shrutim1505]

Ok @karanBRAVO can u open a new PR for the same?