Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI proposed #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UI proposed #43

wants to merge 1 commit into from

Conversation

Shrutim1505
Copy link
Contributor

Screenshot from 2025-02-19 14-07-04

@Shrutim1505
ui proposed
baf83bb 
Signed-off-by: Shruti78 <[email protected]>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shrutim1505
Copy link
Contributor Author

/assign @kevin-wangzefeng

@Shrutim1505
Copy link
Contributor Author

Shrutim1505 commented Feb 27, 2025 •
edited
Loading

@Monokaix is this change viable?

de6p
de6p reviewed Mar 6, 2025
View reviewed changes
frontend/src/components/Jobs.jsx
import {fetchAllNamespaces, fetchAllQueues} from "./utils";
import { fetchAllNamespaces, fetchAllQueues } from "./utils";

const brandColor = "#eb301a";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could define these colors in constants.js, so we don't have to redefine them every time

@Monokaix Monokaix requested a review from Copilot March 25, 2025 06:44
Copilot
Copilot AI reviewed Mar 25, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces visual updates to the Jobs dashboard, aiming to enhance the overall UI design and user interactivity.

  • Implements a new Card layout with a gradient header and updated typography.
  • Applies a consistent brand color scheme across components and refines pagination controls.
  • Enhances error display and dialog styling for clearer user feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de6p de6p de6p left review comments

Copilot code review Copilot Copilot left review comments

@Monokaix Monokaix Awaiting requested review from Monokaix

@william-wang william-wang Awaiting requested review from william-wang

Assignees

@kevin-wangzefeng kevin-wangzefeng

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shrutim1505 @volcano-sh-bot @de6p @kevin-wangzefeng