-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar UI updated #41
base: main
Are you sure you want to change the base?
Sidebar UI updated #41
Conversation
Signed-off-by: Himanshityagii24 <[email protected]>
Signed-off-by: Himanshityagii24 <[email protected]>
f8b8cb6
to
ddf1ab7
Compare
/assign @kevin-wangzefeng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Himanshityagii24 can u please specify behaviour of drawer??
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shrutim1505 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Shrutim1505: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -14,6 +14,8 @@ | |||
"@emotion/styled": "^11.14.0", | |||
"@mui/icons-material": "^6.4.4", | |||
"@mui/material": "^6.4.4", | |||
"@popperjs/core": "^2.11.8", | |||
"@rollup/rollup-win32-x64-msvc": "^4.34.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we require this @rollup/rollup-win32-x64-msvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend changes are included here. Please ensure they are covered in separate PRs, as it is confusing. Kindly separate the backend changes.
// @Monokaix @JesseStutler
@de6p: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yeah I agree, seperate the frontend and backend into different Pr is better. |
Sidebar UI Improvement****
Changes:

1.Logo Positioning Changes
2.Added nested hover effects in the drawer's sx prop
3.Added animations for icon and text on hover
4.Color Adjustments
5.Applied transitions to multiple elements for smooth animations
6.List Item Styling
Here is the look: