refactor: file resource #2437
Merged
refactor: file resource #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacegospod
previously approved these changes
Apr 29, 2025
iBrandyJackson
previously approved these changes
Apr 29, 2025
tenthirtyam
dismissed stale reviews from iBrandyJackson and spacegospod
via
35b3d02
tenthirtyam
force-pushed
the
refactor/file-resource
branch
from
76354aa to
35b3d02
Compare
tenthirtyam
force-pushed
the
refactor/file-resource
branch
from
35b3d02 to
527071f
Compare
- Refactors the `deleteFile` function, reducing the code duplication in the task execution and waiting logic. - Adds comments for file resource functions, including test functions. - Moves supporting functions below the CRUD functions. - Adds description to the file resource schema. - Update the file resource documentation. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
refactor/file-resource
branch
from
527071f to
d103f3c
Compare
iBrandyJackson
approved these changes
Apr 30, 2025
|
This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deleteFilefunction, reducing the code duplication in the task execution and waiting logic.Note: Revisit this resource with a transition to
terraform-plugin-logand potentionally move supporting functions to a helper.