refactor: use switch statement for os customization type #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the if-else if chain checking `specItem.Info.Type` with a switch statement. Using `switch` on the type variable is more idiomatic Go and often improves readability when dispatching logic based on the value of a single variable, especially when more cases might be added later. Signed-off-by: Ryan Johnson <[email protected]>
spacegospod
approved these changes
Apr 29, 2025
iBrandyJackson
approved these changes
Apr 29, 2025
|
This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the if-else if chain checking
specItem.Info.Typewith a switch statement.Using
switchon the type variable is more idiomatic Go and often improves readability when dispatching logic based on the value of a single variable, especially when more cases might be added later.