Skip to content

fix: staticcheck S1039 #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: staticcheck S1039 #2425

merged 1 commit into from
Apr 29, 2025

Conversation

tenthirtyam
Copy link
Contributor

Description

Fixes unnecessary use of fmt.Sprint.

Before:

~/Downloads/terraform-provider-vsphere git:[fix/staticcheck-S1039]
golangci-lint run
vsphere/resource_vsphere_virtual_machine_class_test.go:42:9: S1039: unnecessary use of fmt.Sprintf (staticcheck)
        return fmt.Sprintf(`
               ^
vsphere/resource_vsphere_virtual_machine_class_test.go:53:9: S1039: unnecessary use of fmt.Sprintf (staticcheck)
        return fmt.Sprintf(`

2 issues:
* staticcheck: 2

After:

~/Downloads/terraform-provider-vsphere git:[fix/staticcheck-S1039]
golangci-lint run
0 issues.

Fixes unnecessary use of `fmt.Sprint`.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added technical-debt Technical Debt refactor Refactor labels Apr 26, 2025
@tenthirtyam tenthirtyam added this to the v2.13.0 milestone Apr 26, 2025
@tenthirtyam tenthirtyam requested a review from spacegospod April 26, 2025 16:20
@tenthirtyam tenthirtyam self-assigned this Apr 26, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 26, 2025 16:20
@tenthirtyam tenthirtyam added the needs-review Needs Review label Apr 26, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 29, 2025
@tenthirtyam tenthirtyam merged commit 254c8cc into main Apr 29, 2025
8 checks passed
@tenthirtyam tenthirtyam deleted the fix/staticcheck-S1039 branch April 29, 2025 19:03
Copy link

This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants