Skip to content

fix: error not checked #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix: error not checked #2421

merged 1 commit into from
Apr 30, 2025

Conversation

tenthirtyam
Copy link
Contributor

Description

Fixes error not checked identified by golangci-lint.

Before:

~/Downloads/terraform-provider-vsphere git:[fix/error-not-checked]
golangci-lint run
vsphere/data_source_vsphere_datacenter.go:53:20: Error return value of `view.Destroy` is not checked (errcheck)
        defer view.Destroy(ctx)
                          ^
vsphere/distributed_virtual_switch_helper.go:176:11: Error return value of `task.Wait` is not checked (errcheck)
        task.Wait(tctx)
                 ^
2 issues:
* errcheck: 2

After:

~/Downloads/terraform-provider-vsphere git:[fix/error-not-checked]
golangci-lint run
0 issues.

@tenthirtyam tenthirtyam added technical-debt Technical Debt refactor Refactor labels Apr 26, 2025
@tenthirtyam tenthirtyam requested a review from spacegospod April 26, 2025 15:38
@tenthirtyam tenthirtyam self-assigned this Apr 26, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 26, 2025 15:38
@tenthirtyam tenthirtyam added this to the v2.13.0 milestone Apr 26, 2025
@tenthirtyam tenthirtyam added the needs-review Needs Review label Apr 26, 2025
spacegospod
spacegospod previously approved these changes Apr 29, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 29, 2025
iBrandyJackson
iBrandyJackson previously approved these changes Apr 29, 2025
@tenthirtyam tenthirtyam dismissed stale reviews from iBrandyJackson and spacegospod via 15e60c4 April 29, 2025 18:58
@tenthirtyam tenthirtyam force-pushed the fix/error-not-checked branch from 707c318 to 15e60c4 Compare April 29, 2025 18:58
@tenthirtyam tenthirtyam force-pushed the fix/error-not-checked branch 2 times, most recently from 0d5c3c8 to b9b7649 Compare April 29, 2025 22:27
Fixes error not checked identified by `golangci-lint`.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the fix/error-not-checked branch from b9b7649 to fa93990 Compare April 30, 2025 13:53
@tenthirtyam tenthirtyam merged commit bf3c621 into main Apr 30, 2025
8 checks passed
@tenthirtyam tenthirtyam deleted the fix/error-not-checked branch April 30, 2025 15:21
Copy link

This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants