fix: revive var-naming #2415
Merged
fix: revive var-naming #2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacegospod
reviewed
Apr 29, 2025
vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource.go
Show resolved
Hide resolved
vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource.go
Show resolved
Hide resolved
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
from
02e53e6 to
a3969e0
Compare
iBrandyJackson
previously approved these changes
Apr 29, 2025
|
Will await a re-review from @spacegospod before merging since this was a big update to correct variable names to the idiomatic format and helping to avoid variable vs argument/attribute references. |
|
This one will need a rebase to proceed. Will address this tomorrow. |
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
4 times, most recently
from
fdbf67e to
25499dc
Compare
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
from
25499dc to
eba698b
Compare
|
@spacegospod @iBrandyJackson - this one is ready after addressing the prior comments. |
tenthirtyam
force-pushed
the
main
branch
2 times, most recently
from
2d0d0cd to
3ebb159
Compare
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
from
eba698b to
ed63aac
Compare
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
from
ed63aac to
000822f
Compare
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
from
000822f to
1ab0ccc
Compare
Rename variables based on idiomatic principles, per `revive` and `golangci-lint`. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
fix/revive-var-naming
branch
from
1ab0ccc to
b43c249
Compare
dougm
approved these changes
May 7, 2025
|
This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename variables based on idiomatic principles, per
reviveandgolangci-lint.~/Downloads/terraform-provider-vsphere git:[fix/revive-var-naming] golangci-lint run 0 issues.