Skip to content

feat: use ForceNew for entity_id and entity_type on r/vsphere_entity_permission #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Apr 23, 2025

Description

Changes to entity_id and entity_type block terraform apply. This PR removes this restriction and forces a re-creation of the resource if either of these properties is changed.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Release Note

Release note for CHANGELOG:

`r/vsphere_entity_permission`: Changes to `entity_id` and `entity_type` will cause instances to be recreated.

References

Closes #2385

@spacegospod spacegospod self-assigned this Apr 23, 2025
@spacegospod spacegospod requested a review from a team as a code owner April 23, 2025 12:32
@spacegospod
Copy link
Contributor Author

@tenthirtyam can we consider this a non-breaking change?

@tenthirtyam
Copy link
Contributor

I would consider this non-breaking.

@tenthirtyam tenthirtyam changed the title feat: Use ForceNew for entity_id and entity_type on r/vsphere_entity_permission feat: use ForceNew for entity_id and entity_type on r/vsphere_entity_permission Apr 23, 2025
@tenthirtyam tenthirtyam added this to the v2.13.0 milestone Apr 23, 2025
@tenthirtyam tenthirtyam added the enhancement Enhancement label Apr 23, 2025
@tenthirtyam tenthirtyam merged commit ba95a11 into main Apr 23, 2025
7 checks passed
@tenthirtyam tenthirtyam deleted the bug/permission branch April 23, 2025 15:52
Copy link

This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/vsphere_entity_permissions doesn't handle changing entity ID correctly
3 participants