Skip to content

chore(deps): testing migration #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

tenthirtyam
Copy link
Contributor

Description

Migrate a provider's acceptance tests from SDKv2 to the testing module, github.com/hashicorp/terraform-plugin-testing:

  • github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest >>> github.com/hashicorp/terraform-plugin-testing/helper/acctest
  • github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource >>> github.com/hashicorp/terraform-plugin-testing/helper/resource
  • github.com/hashicorp/terraform-plugin-sdk/v2/terraform >>> github.com/hashicorp/terraform-plugin-testing/terraform

Areas where the provider uses terraform.InstanceState must remain with the original import since it is testing terraform-plugin-sdk functionality.

This may be removed later as it's relevent to state migration code from 7+ years ago.

Reference

Migrating from SDK

@tenthirtyam tenthirtyam added the chore Chore label Apr 22, 2025
@tenthirtyam tenthirtyam requested a review from spacegospod April 22, 2025 01:55
@tenthirtyam tenthirtyam self-assigned this Apr 22, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 22, 2025 01:55
@tenthirtyam tenthirtyam added this to the v2.13.0 milestone Apr 22, 2025
@tenthirtyam tenthirtyam added the technical-debt Technical Debt label Apr 23, 2025
Migrate a provider's acceptance tests from SDKv2 to the testing module, `github.com/hashicorp/terraform-plugin-testing`:

- `github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest` >>> `github.com/hashicorp/terraform-plugin-testing/helper/acctest`
- `github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource` >>> `github.com/hashicorp/terraform-plugin-testing/helper/resource`
- `github.com/hashicorp/terraform-plugin-sdk/v2/terraform` >>> `github.com/hashicorp/terraform-plugin-testing/terraform`

Areas where the provider uses `terraform.InstanceState` must remain with the original import since it is testing terraform-plugin-sdk functionality.

This may be removed later as it's relevent to state migration code from 7+ years ago.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore(deps)/testing-migration branch from 441a42a to 29a2164 Compare April 23, 2025 15:01
@tenthirtyam tenthirtyam merged commit 751737b into main Apr 23, 2025
7 checks passed
@tenthirtyam tenthirtyam deleted the chore(deps)/testing-migration branch April 23, 2025 15:49
Copy link

This functionality has been released in v2.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants