Skip to content

chore: remove use of io/ioutil #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: remove use of io/ioutil #48

merged 1 commit into from
Jan 13, 2025

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Removes the use of io/ioutil.

As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations are preferred in new code.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Dependent on #47.

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the chore Chore label Jan 9, 2025
@tenthirtyam tenthirtyam added this to the .next milestone Jan 9, 2025
@tenthirtyam tenthirtyam self-assigned this Jan 9, 2025
@github-actions github-actions bot added dependencies Dependencies needs-review Needs Review provider Provider documentation Documentation labels Jan 9, 2025
@tenthirtyam tenthirtyam changed the title Chore/remove io ioutil chore: remove use of io/ioutil Jan 9, 2025
@tenthirtyam tenthirtyam modified the milestones: .next, v0.4.4 Jan 10, 2025
@tenthirtyam tenthirtyam force-pushed the chore/remove-io-ioutil branch from 30fd4fc to 7b22c29 Compare January 10, 2025 20:25
@tenthirtyam tenthirtyam marked this pull request as ready for review January 10, 2025 20:25
@tenthirtyam tenthirtyam requested a review from andybeltz January 10, 2025 20:26
Copy link

@andybeltz andybeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam modified the milestones: v0.4.4, .next Jan 12, 2025
@tenthirtyam tenthirtyam force-pushed the main branch 11 times, most recently from 097f513 to fb2b41d Compare January 13, 2025 18:08
Removes the use of `io/ioutil`.

As of Go 1.16, the same functionality is now provided by package `io` or package `os`, and those implementations are preferred in new code.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore/remove-io-ioutil branch from 7b22c29 to 6d8c5a3 Compare January 13, 2025 20:57
@tenthirtyam tenthirtyam merged commit aa59eb4 into main Jan 13, 2025
3 checks passed
@tenthirtyam tenthirtyam deleted the chore/remove-io-ioutil branch January 13, 2025 20:58
tenthirtyam added a commit that referenced this pull request Jan 15, 2025
Removes the use of `io/ioutil`.

As of Go 1.16, the same functionality is now provided by package `io` or package `os`, and those implementations are preferred in new code.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam modified the milestones: .next, v0.5.1 Jan 15, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 15, 2025
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Chore dependencies Dependencies documentation Documentation provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants