🐛 Do not watch child folders #921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
fix/do-not-watch-podvms
branch
from
7845d50 to
c614c9a
Compare
This patch changes the behavior of the async watcher service to no longer watch child folders under the Namespace's folder. Otherwise PodVMs are caught in the mix. To ensure VM Op still watches the folders created for VKS clusters, these folders are explicitly added to the watcher.
akutz
force-pushed
the
fix/do-not-watch-podvms
branch
from
c614c9a to
57b4459
Compare
Minimum allowed line rate is |
dilyar85
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch changes the behavior of the async watcher service to no longer watch child folders under the Namespace's folder. Otherwise PodVMs are caught in the mix.
To ensure VM Op still watches the folders created for VKS clusters, these folders are explicitly added to the watcher.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
This is a WiP that needs tests. It's also unclear if I will have time to take it over the finish line or if this is even the correct solution. I'm opening this as a WiP PR primarily so folks can more easily add comments and thoughts.
Please add a release note if necessary: