-
Notifications
You must be signed in to change notification settings - Fork 54
✨ Support consumption of Image Registry Operator API v1alpha2
in (Cluster)ContentLibraryItem controller(s)
#1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abaruni
wants to merge
2
commits into
vmware-tanzu:main
Choose a base branch
from
abaruni:topic/ab002705/VMSVC-2571
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e33bc23
to
a83e2a6
Compare
0c6fbdd
to
e90a335
Compare
supports_inventory_content_library
capabilityv1alpha2
in (Cluster)ContentLibraryItem controller(s)
v1alpha2
in (Cluster)ContentLibraryItem controller(s)v1alpha2
in (Cluster)ContentLibraryItem controller(s)
82d0d3b
to
8762a5d
Compare
Minimum allowed line rate is |
bryanv
approved these changes
Jul 9, 2025
lubronzhan
reviewed
Jul 9, 2025
@@ -0,0 +1,503 @@ | |||
// © Broadcom. All Rights Reserved. | |||
// The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Suggested change
// The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. | |
// The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries. |
@@ -0,0 +1,740 @@ | |||
// © Broadcom. All Rights Reserved. | |||
// The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Suggested change
// The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. | |
// The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This PR adds support for consuming Image Registry Operator API
v1alpha2
in theContentLibraryItem
andClusterContentLibraryItem
controllers.Additionally this PR add support for the
supports_inventory_content_library
capability necessary for consuming these new APIs.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: