Skip to content

[TKG-29306] Filter user permission #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented Feb 5, 2025

What this PR does / why we need it:

  1. Filter permissions, remove the one that's been deprecated in corresponding AVI Controller version
  2. Add username to user object if it's enterprise license
  3. More logging
  4. Refactor makefile and dockerfile

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9 branch from 4a2a0d1 to 3a42064 Compare February 5, 2025 04:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 15.00000% with 51 lines in your changes missing coverage. Please review.

Project coverage is 31.91%. Comparing base (ca3de2a) to head (681d63d).

Files with missing lines Patch % Lines
...ollers/akodeploymentconfig/user/user_controller.go 17.64% 42 Missing ⚠️
controllers/akodeploymentconfig/user/ako_role.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   32.16%   31.91%   -0.25%     
==========================================
  Files          32       33       +1     
  Lines        3616     3653      +37     
==========================================
+ Hits         1163     1166       +3     
- Misses       2383     2417      +34     
  Partials       70       70              
Files with missing lines Coverage Δ
controllers/akodeploymentconfig/user/ako_role.go 0.00% <0.00%> (ø)
...ollers/akodeploymentconfig/user/user_controller.go 9.55% <17.64%> (+0.10%) ⬆️

@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9 branch 2 times, most recently from 6365671 to 027955a Compare February 5, 2025 21:31
sunjayBhatia
sunjayBhatia previously approved these changes Feb 12, 2025
@lubronzhan
Copy link
Contributor Author

Hi @sunjayBhatia could you approve again? The rebasing dismissed the approval

@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9 branch from 431c17a to 681d63d Compare February 13, 2025 22:13
Copy link
Contributor

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubronzhan lubronzhan merged commit 856954b into vmware-tanzu:main Feb 14, 2025
4 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/test_avi_vc9 branch February 14, 2025 01:44
lubronzhan added a commit that referenced this pull request Feb 14, 2025
Cherry pick #369

Filter permissions, remove the one that's been deprecated in corresponding AVI Controller version
Add username to user object if it's enterprise license
More logging
Refactor makefile and dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants