-
Notifications
You must be signed in to change notification settings - Fork 11
[TKG-29306] Filter user permission #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lubronzhan
merged 1 commit into
vmware-tanzu:main
from
lubronzhan:topic/lubron/test_avi_vc9
Feb 14, 2025
Merged
[TKG-29306] Filter user permission #369
lubronzhan
merged 1 commit into
vmware-tanzu:main
from
lubronzhan:topic/lubron/test_avi_vc9
Feb 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a2a0d1
to
3a42064
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 32.16% 31.91% -0.25%
==========================================
Files 32 33 +1
Lines 3616 3653 +37
==========================================
+ Hits 1163 1166 +3
- Misses 2383 2417 +34
Partials 70 70
|
6365671
to
027955a
Compare
sunjayBhatia
previously approved these changes
Feb 12, 2025
027955a
to
431c17a
Compare
Hi @sunjayBhatia could you approve again? The rebasing dismissed the approval |
Some refactor
431c17a
to
681d63d
Compare
sunjayBhatia
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lubronzhan
added a commit
that referenced
this pull request
Feb 14, 2025
Cherry pick #369 Filter permissions, remove the one that's been deprecated in corresponding AVI Controller version Add username to user object if it's enterprise license More logging Refactor makefile and dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Describe testing done for PR:
Special notes for your reviewer:
Release note:
New PR Checklist