Skip to content

fix cluster upgrade ako role doesn't update issue #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

XudongLiuHarold
Copy link
Contributor

@XudongLiuHarold XudongLiuHarold commented Aug 16, 2023

What this PR does / why we need it:

  • fix when cluster upgrade, ako-oprator doesn't update ako-essential-role to align with latest permission

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:

NONE

New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@XudongLiuHarold XudongLiuHarold force-pushed the topic/xudongl/fix-upgrade-cluster-ako-role-issue branch from 2e5cf87 to 3866741 Compare August 16, 2023 08:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #159 (f600c84) into release-1.10.0 (1649072) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0     #159      +/-   ##
==================================================
- Coverage           32.93%   32.63%   -0.30%     
==================================================
  Files                  19       19              
  Lines                2508     2531      +23     
==================================================
  Hits                  826      826              
- Misses               1626     1649      +23     
  Partials               56       56              
Files Changed Coverage Δ
...ollers/akodeploymentconfig/user/user_controller.go 0.00% <0.00%> (ø)

@XudongLiuHarold XudongLiuHarold force-pushed the topic/xudongl/fix-upgrade-cluster-ako-role-issue branch 10 times, most recently from b558cea to 6269e0d Compare August 16, 2023 12:09
@XudongLiuHarold XudongLiuHarold force-pushed the topic/xudongl/fix-upgrade-cluster-ako-role-issue branch from 6269e0d to d892084 Compare August 17, 2023 06:27
@XudongLiuHarold XudongLiuHarold force-pushed the topic/xudongl/fix-upgrade-cluster-ako-role-issue branch from d892084 to abf0329 Compare August 17, 2023 06:35
@XudongLiuHarold XudongLiuHarold merged commit 53caa07 into release-1.10.0 Aug 17, 2023
@XudongLiuHarold XudongLiuHarold deleted the topic/xudongl/fix-upgrade-cluster-ako-role-issue branch August 17, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants