Skip to content

SelectFrame in case screenshot-all #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shenlian8 opened this issue Jan 10, 2020 · 2 comments
Closed

SelectFrame in case screenshot-all #315

shenlian8 opened this issue Jan 10, 2020 · 2 comments
Assignees

Comments

@shenlian8
Copy link
Contributor

Hi,

if screenshot-all is set to true and selectFrame is used.

After selectFrame in takeScreenshot function in Runner class, it is called this.driver.switchTo().defaultContent();

So I think in selectFrame, the
public boolean mayUpdateScreen() {
return false;
}
must be set.

What do you think?

Lian

@vmi vmi self-assigned this Jan 15, 2020
@vmi vmi added the bug label Feb 2, 2020
@vmi
Copy link
Owner

vmi commented Feb 2, 2020

Hi,

I fixed this problem and and released 3.29.0.
Please test it.

@vmi
Copy link
Owner

vmi commented Dec 9, 2020

Please re-open this issue if your problem is not resolved.

@vmi vmi closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants