Skip to content
This repository was archived by the owner on Sep 1, 2020. It is now read-only.

Fix bug for menu not showing when page is scrolled #69

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

mil3na
Copy link
Contributor

@mil3na mil3na commented Jan 27, 2017

Hi :)

We noticed a bug that, when you scroll a page, the context menu appears far away from the pointer. This bug can be reproduced using the latest version of Firefox, using the examples page.

Apparently, the event position is more than enough to position the menu. If there's a reason to keep the addition of scrolling, please let me know.

Cheers.

@vkbansal
Copy link
Owner

Can you attach a GIF showing how to reproduce the issue?

@mil3na
Copy link
Contributor Author

mil3na commented Jan 29, 2017

Sure! There you go:

2017-01-29 13 23 16

I tweked the size of the example table just to have scroll bars. Here's the code:

.table {
    height:800px;
    width:1000px;
    max-width:1000px;
}

@vkbansal
Copy link
Owner

vkbansal commented Feb 1, 2017

I'll merge this if you can confirm, this does not break in safari and chrome.

@mil3na
Copy link
Contributor Author

mil3na commented Feb 1, 2017

I can test it only on OSX, but here's a gif showing how the fix behaves on safari, firefox and chrome:

2017-02-01 19 38 26

@vkbansal vkbansal merged commit ba3dc57 into vkbansal:master Feb 2, 2017
@PaulIPS
Copy link

PaulIPS commented Jul 6, 2017

@vkbansal @mil3na I am seeing this same issue on IOS using Safari. I can confirm it's working fine on OSX in Chrome, Firefox and Safari.

@alolis
Copy link

alolis commented Oct 30, 2017

@vkbansal @mil3na I am still seeing the issue with react-contextmenu v.2.8.0 on my iPad with Safari but it's also happening under latest Chrome (v62.0.3202.70) and latest Firefox (v9.3 build 7374) for iOS. I am using latest iOS v11.0.3.

@PaulScala , did you manage to resolve this somehow?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants