Skip to content

fix(browser): print correct stack trace in source files #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sheremet-va
Copy link
Member

Description

Fixes #5996

Previously the browser mode printed the correct stack trace only if the error was inside the test file because of incorrect stack trace parsing (files were resolved relative to the server (/src/file.js) instead of being absolute (/home/project/src/file.js)).

Also, I think working with printError is quite hard at this stage - maybe we should refactor it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va merged commit 62aa720 into vitest-dev:main Jun 30, 2024
16 checks passed
@sheremet-va sheremet-va deleted the fix/correct-stack-trace-browser-src branch June 30, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception stack trace line numbers are wrong in browser mode
1 participant