Skip to content

fix(forks): resolve poolOptions.<name>.isolate from forks options #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 4, 2024

Description

This is working fine when using workspaces:

poolOptions: {
forks: {
singleFork: poolOptions?.forks?.singleFork ?? this.ctx.config.poolOptions?.forks?.singleFork ?? false,
isolate: poolOptions?.forks?.isolate ?? isolate ?? this.ctx.config.poolOptions?.forks?.isolate ?? true,
},

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio force-pushed the fix/forks-isolate-in-pool-options branch from 0f4d8c9 to d84efc8 Compare June 4, 2024 12:02
@AriPerkkio AriPerkkio marked this pull request as ready for review June 4, 2024 12:05
@sheremet-va sheremet-va merged commit a60a140 into vitest-dev:main Jun 11, 2024
16 checks passed
@AriPerkkio AriPerkkio deleted the fix/forks-isolate-in-pool-options branch June 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants