-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(vitest): add new CLI options #5163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AriPerkkio do you think we should add watermarks to CLI options? With the new |
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
If supporting it is not too difficult, then sure let's add it. So {
statements: [50, 80], // Default value
functions: [10, 20],
branches: [50, 80], // Default value
lines: [10, 20]
} |
Do we need to merge them ourselves? Right now you can pass down |
Oh right - we don't need to worry about the defaults. Istanbul will merge these automatically with the default ones. So {
functions: [10, 20],
lines: [10, 20]
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The test cases in cli-test.test.ts
are perfect. This is something we've been missing from CLI option testing for a long time.
Description
This PR adds a few easy-to-justify options to the CLI:
--hookTimeout
--teardownTimeout
--slowTestThreshold
--maxConcurrency
--no-cache
--cache.dir
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.