fix(vitest): initialize snapshot state only once for each file suite #4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
hi-ogawa
commented
Dec 22, 2023
Comment on lines
+30
to
+38
| async onAfterRunSuite(suite: Suite) { | ||
| if (this.config.logHeapUsage && typeof process !== 'undefined') | ||
| suite.result!.heap = process.memoryUsage().heapUsed | ||
|
|
||
| if (suite.mode !== 'skip' && typeof suite.filepath !== 'undefined') { | ||
| const result = await this.snapshotClient.finishCurrentRun() | ||
| if (result) | ||
| await rpc().snapshotSaved(result) | ||
| } |
There was a problem hiding this comment.
I moved finishCurrentRun from onAfterRunFiles hook to onAfterRunSuite hook as a refactoring since it would match with calling startCurrentRun in onBeforeRunSuite.
6 tasks
6 tasks
sheremet-va
approved these changes
Dec 28, 2023
6 tasks
This was referenced Jan 1, 2024
1 task
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4782
Closes #3361
Closes #4793 (Alternative PR)
I felt the problem is more on how
VitestTestRunnerusesSnapshotClientthanSnapshotClient.startCurrentRunitself, so I attempted an alternative approach to fixVitestTestRunnerside.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.