-
Notifications
You must be signed in to change notification settings - Fork 2.2k
VTGate: Session in StreamExecute response as default #17907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTGate: Session in StreamExecute response as default #17907
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <[email protected]>
4dfc37b
to
9042955
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17907 +/- ##
==========================================
+ Coverage 67.50% 67.54% +0.04%
==========================================
Files 1597 1597
Lines 259761 259770 +9
==========================================
+ Hits 175344 175456 +112
+ Misses 84417 84314 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do we have an issue created for what needs to be done in v23? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Deepthi's comment needs to be addressed.
Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Harshit Gangal <[email protected]>
Issue exists now #17913 |
Description
This PR enables
grpc-send-session-in-streaming
astrue
by default and mark the flag as deprecated to be removed from future release.Related Issue(s)
Checklist
Deployment Notes