fix(css): resolve relative imports in sass properly on Windows #19920

sapphi-red · 2025-04-23T11:49:20Z

Description

fileURLToPath('file:///C:/foo.js', { windows: false }) returns /C:/foo.js. Even with this output, it still worked because the internal resolve plugin supports that format (/C:/foo.js) as well.

vite/packages/vite/src/node/plugins/resolve.ts

Lines 262 to 274 in 16a73c0

    
           // URL 
        
           // /foo -> /fs-root/foo 
        
           if ( 
        
             asSrc && 
        
             id[0] === '/' && 
        
             (rootInRoot || !id.startsWith(withTrailingSlash(root))) 
        
           ) { 
        
             const fsPath = path.resolve(root, id.slice(1)) 
        
             if ((res = tryFsResolve(fsPath, options))) { 
        
               debug?.(`[url] ${colors.cyan(id)} -> ${colors.dim(res)}`) 
        
               return ensureVersionQuery(res, id, options, depsOptimizer) 
        
             } 
        
           }

But the expected result here for this input is C:/foo.js, and this PR fixes the condition to use windows option.

bluwy

Makes sense to me 👍

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 6.3.2 | 6.3.3 | ## [v6.3.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small633-2025-04-24-small) - fix: ignore malformed uris in tranform middleware ([#19853](vitejs/vite#19853)) ([e4d5201](vitejs/vite@e4d5201)), closes [#19853](vitejs/vite#19853) - fix(assets): ensure ?no-inline is not included in the asset url in the production environment ([#1949](vitejs/vite#1949) ([16a73c0](vitejs/vite@16a73c0)), closes [#19496](vitejs/vite#19496) - fix(css): resolve relative imports in sass properly on Windows ([#19920](vitejs/vite#19920)) ([ffab442](vitejs/vite@ffab442)), closes [#19920](vitejs/vite#19920) - fix(deps): update all non-major dependencies ([#19899](vitejs/vite#19899)) ([a4b500e](vitejs/vite@a4b500e)), closes [#19899](vitejs/vite#19899) - fix(ssr): fix execution order of re-export ([#19841](vitejs/vite#19841)) ([ed29dee](vitejs/vite@ed29dee)), closes [#19841](vitejs/vite#19841) - fix(ssr): fix live binding of default export declaration and hoist exports getter ([#19842](vitejs/vite#19842)) ([80a91ff](vitejs/vite@80a91ff)), closes [#19842](vitejs/vite#19842) - perf: skip sourcemap generation for renderChunk hook of import-analysis-build plugin ([#19921](vitejs/vite#19921)) ([55cfd04](vitejs/vite@55cfd04)), closes [#19921](vitejs/vite#19921) - test(ssr): test `ssrTransform` re-export deps and test stacktrace with first line ([#19629](vitejs/vite#19629)) ([9399cda](vitejs/vite@9399cda)), closes [#19629](vitejs/vite#19629)

| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 6.3.2 | 6.3.4 | ## [v6.3.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small634-2025-04-30-small) - fix: check static serve file inside sirv ([#19965](vitejs/vite#19965)) ([c22c43d](vitejs/vite@c22c43d)), closes [#19965](vitejs/vite#19965) - fix(optimizer): return plain object when using `require` to import externals in optimized dependenci ([efc5eab](vitejs/vite@efc5eab)), closes [#19940](vitejs/vite#19940) - refactor: remove duplicate plugin context type ([#19935](vitejs/vite#19935)) ([d6d01c2](vitejs/vite@d6d01c2)), closes [#19935](vitejs/vite#19935) ## [v6.3.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small633-2025-04-24-small) - fix: ignore malformed uris in tranform middleware ([#19853](vitejs/vite#19853)) ([e4d5201](vitejs/vite@e4d5201)), closes [#19853](vitejs/vite#19853) - fix(assets): ensure ?no-inline is not included in the asset url in the production environment ([#1949](vitejs/vite#1949) ([16a73c0](vitejs/vite@16a73c0)), closes [#19496](vitejs/vite#19496) - fix(css): resolve relative imports in sass properly on Windows ([#19920](vitejs/vite#19920)) ([ffab442](vitejs/vite@ffab442)), closes [#19920](vitejs/vite#19920) - fix(deps): update all non-major dependencies ([#19899](vitejs/vite#19899)) ([a4b500e](vitejs/vite@a4b500e)), closes [#19899](vitejs/vite#19899) - fix(ssr): fix execution order of re-export ([#19841](vitejs/vite#19841)) ([ed29dee](vitejs/vite@ed29dee)), closes [#19841](vitejs/vite#19841) - fix(ssr): fix live binding of default export declaration and hoist exports getter ([#19842](vitejs/vite#19842)) ([80a91ff](vitejs/vite@80a91ff)), closes [#19842](vitejs/vite#19842) - perf: skip sourcemap generation for renderChunk hook of import-analysis-build plugin ([#19921](vitejs/vite#19921)) ([55cfd04](vitejs/vite@55cfd04)), closes [#19921](vitejs/vite#19921) - test(ssr): test `ssrTransform` re-export deps and test stacktrace with first line ([#19629](vitejs/vite#19629)) ([9399cda](vitejs/vite@9399cda)), closes [#19629](vitejs/vite#19629)

fix(css): resolve relative imports in sass properly on Windows

2bb2368

sapphi-red added feat: css p2-edge-case Bug, but has workaround or limited in scope (priority) labels Apr 23, 2025

bluwy approved these changes Apr 23, 2025

View reviewed changes

sapphi-red merged commit ffab442 into vitejs:main Apr 24, 2025
17 checks passed

sapphi-red deleted the fix/css-sass-relative-windows-properly branch April 24, 2025 02:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(css): resolve relative imports in sass properly on Windows #19920

fix(css): resolve relative imports in sass properly on Windows #19920

sapphi-red commented Apr 23, 2025

bluwy left a comment

	// URL
	// /foo -> /fs-root/foo
	if (
	asSrc &&
	id[0] === '/' &&
	(rootInRoot \|\| !id.startsWith(withTrailingSlash(root)))
	) {
	const fsPath = path.resolve(root, id.slice(1))
	if ((res = tryFsResolve(fsPath, options))) {
	debug?.(`[url] ${colors.cyan(id)} -> ${colors.dim(res)}`)
	return ensureVersionQuery(res, id, options, depsOptimizer)
	}
	}

fix(css): resolve relative imports in sass properly on Windows #19920

fix(css): resolve relative imports in sass properly on Windows #19920

Conversation

sapphi-red commented Apr 23, 2025

Description

bluwy left a comment

Choose a reason for hiding this comment